Windows ccache support #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt uses quoted includes in Framework headers (which is discouraged by Apple) and also has some questionable use of the comma operator.
clang expects an empty prototype to explicitly use `void`. Also silences the warning in `libobs-opengl`, `obsglad`, `caption`, `mac-syphon` and `obs-x264-test`.
The branch is never taken and the code acts as documentation for a (possible) future use case. According to YAGNI it could be removed entirely, wrapping it in a comment is the less destructive approach.
Source code is generated by Swig, so we just silence the warning.
The FTL SDK is outdated and not actively maintained - the warnings are known and acknowledged, so there is no need to further pollute the build output with them.
Frameworks should be archived and exported (where they will be codesigned by Xcode) or shipped within an App bundle where Xcode will also take care of it.
Also updates Ninja-based clang settings to ensure builds fail on same compilation issues.
PatTheMav
force-pushed
the
windows-ccache-support
branch
from
a85c063
to
b295c90
Compare
Include guards ensure that bootstrap includes happen only once for the entire project. Moving all policy changes into an included file without its own policy scope ensures that the policy is applied to the project.
Compiler extensions are disabled before the first `project` call to force CMake into considering compilers to not support GNU extensions (even though clang and gcc do). Also sets common clang compiler options so they can be used across all supported platforms. `openmp-simd` support is enabled by default as there is no performance penalty on x86_64 systems and intrinsics are enabled on arm64. Also implements CMake's `CMAKE_COMPILE_WARNING_AS_ERROR` flag to enable the desired behavior and configuration time.
Creation of Info.plist files through Xcode is more canonical and future-proof, as it will automatically pick up changes/updates introduced by Apple. Non-standard keys can still be added via a template file, which will then be extended by Xcode with the default keys.
No 32-bit builds exist anymore, so default to 64-bit subdirectory. While the directory itself is unnecessary, too many user settings might rely on obs64.exe being in that specific directory, so we cannot easily deprecate this location.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
Clang and gcc warning suppression should only occur on platforms which use these compilers by default.
New code path only taken if OBS_CMAKE_VERSION is set to 3.0.0 or greater, old functionality remains unchanged.
PatTheMav
force-pushed
the
windows-ccache-support
branch
from
b295c90
to
a1358a1
Compare
PatTheMav
force-pushed
the
master
branch
2 times, most recently
from
b7d663c
to
4d5b6eb
Compare
PatTheMav
force-pushed
the
master
branch
2 times, most recently
from
368af08
to
81b5881
Compare
PatTheMav
force-pushed
the
master
branch
2 times, most recently
from
ca52b1b
to
7628265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Test