Allow different hash table size for dim/var/attr #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_hash_size_vattr Add 4 new PnetCDF hints. nc_hash_size_dim: Set hash table size for dimension names nc_hash_size_var: Set hash table size for variable names nc_hash_size_gattr: Set hash table size for global attribute names nc_hash_size_vattr: Set hash table size for variable attribute names
* Add constant PNC_HSIZE_DIM, the default hash table size for dimensions. * Add constant PNC_HSIZE_VAR, the default hash table size for variables. * Add constant PNC_HSIZE_VATTR, the default hash table size for attributes per variable. * Add constant PNC_HSIZE_GATTR, the default hash table size for global attributes. * Add PNC_VATTR_ARRAY_GROWBY, which is used to grow the array of attributes per variable. The number of attributes per variable is expected to be much smaller than the global attributes. * Rename some NC_ constant in ncmpio_NC.h to PNC_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the numbers of variables, dimensions, and attributes can be different significantly,
using the same hash table size will not run efficiently and can waste memory allocated.
This PR allows different hash table sizes, which can also be changed by users through
PnetCDF hints.
4 new PnetCDF user hints have been added.
3 new test programs have beed added to test hashing performance.