-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Documentation bug fixes in README snippets #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work in general! My comments are mostly referring to the same thing (placeholders). You can even add a TODO comment next to each placeholder, e.g.:
subnet_id = "/subscription/xxxx/......." # TODO: Put your existing subnet ID here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
The changes apply to the snippets in the README because they did not reflect the modules code after the refactor.
Motivation and Context
#81
How Has This Been Tested?
The snippets were tested manually. After the applied changes, all snippets no longer throw errors during terraform plan.
Types of changes
Checklist