Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Bump AzureRM to v4 and replace deprecated properties #86

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Aug 29, 2024

Description

This PR replaces deprecated properties which stop working in AzureRM provider v4. It also bumps the minimum provider version to v4.0 in modules version constraints.
Change is breaking because in some cases, variable name got changed too.

Motivation and Context

Old properties stop working in v4 of the AzureRM provider.

How Has This Been Tested?

By manually deploying chosen examples.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the bug Something isn't working label Aug 29, 2024
@acelebanski acelebanski requested a review from a team as a code owner August 29, 2024 10:03
@acelebanski
Copy link
Contributor Author

acelebanski commented Sep 4, 2024

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"

Testing job ID: 10698914470
Job result: FAILURE
Job result: FAILURE
Job result: FAILURE

@acelebanski acelebanski changed the title fix: Replace deprecated properties in modules fix: Bump AzureRM to v4 and replace deprecated properties Sep 5, 2024
@acelebanski
Copy link
Contributor Author

acelebanski commented Sep 5, 2024

/idempotence paths="examples/common_vmseries examples/common_vmseries_and_autoscale examples/dedicated_vmseries examples/dedicated_vmseries_and_autoscale examples/gwlb_with_vmseries examples/standalone_panorama examples/standalone_vmseries"

Testing job ID: 10722197738
Job result: SUCCESS

@acelebanski acelebanski linked an issue Sep 6, 2024 that may be closed by this pull request
@acelebanski acelebanski added enhancement New feature or request and removed bug Something isn't working labels Sep 12, 2024
@acelebanski acelebanski changed the title fix: Bump AzureRM to v4 and replace deprecated properties feat!: Bump AzureRM to v4 and replace deprecated properties Sep 12, 2024
Copy link
Contributor

@slawomir-kaczmarek slawomir-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@acelebanski acelebanski merged commit 4010f00 into main Sep 19, 2024
127 checks passed
@acelebanski acelebanski deleted the provider-v4-deprecated-properties-fix branch September 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump minimum terraform version for modules to 3.116
2 participants