Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce VNET custom DNS servers #85

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

acelebanski
Copy link
Contributor

Description

This PR introduces a possibility to specify custom DNS servers for a VNET (default is null which translates to Azure DNS).

Motivation and Context

#76

How Has This Been Tested?

Deployed one of the examples manually.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the enhancement New feature or request label Aug 29, 2024
@acelebanski acelebanski requested a review from a team as a code owner August 29, 2024 08:17
@acelebanski acelebanski linked an issue Aug 29, 2024 that may be closed by this pull request
Copy link
Contributor

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acelebanski acelebanski merged commit fcd73c5 into main Sep 12, 2024
71 checks passed
@acelebanski acelebanski deleted the 76-vnet-custom-dns-feat branch September 12, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom dns servers in vnet sub-module
2 participants