Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2E example with static files required to execute it #46

Merged
merged 164 commits into from
Apr 4, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Apr 2, 2024

Description

PR delivers:

In folder assets all folders (besides example) are copied from develop of repository https://github.com/PaloAltoNetworks/pango. Issue #49 was opened to refactor folder assets.

Motivation and Context

PR was opened to easily check , if autogenerated code works.

How Has This Been Tested?

Code was tested by executing command from README:

go run cmd/codegen/main.go -t mksdk
cd ../generated/pango
PANOS_HOSTNAME='***' PANOS_USERNAME='***' PANOS_PASSWORD='***' go run example/main.go

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

… the issues from `golangci-lint run --enable-all`
# Conflicts:
#	pkg/translate/funcs.go
@sebastianczech
Copy link
Contributor Author

In folder assets all folders (besides example) are copied from develop of repository https://github.com/PaloAltoNetworks/pango. Issue #49 was opened to refactor folder assets.

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated some of these files since this PR has been opened. Looking at assets/errors/panos.go I don't see the UUID error I added as part of the UUID-style-Entry support. Just grab the new stuff.

@sebastianczech
Copy link
Contributor Author

I've updated some of these files since this PR has been opened. Looking at assets/errors/panos.go I don't see the UUID error I added as part of the UUID-style-Entry support. Just grab the new stuff.

I updated assets from branch develop of pango repository.

@pimielowski pimielowski requested a review from shinmog April 3, 2024 20:47
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! 👍

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pango internals are not "fully baked" yet, there is still a lot that needs to be added in... But this is fine as a starting point for the generator.

Base automatically changed from render-service to main April 4, 2024 12:59
@sebastianczech sebastianczech merged commit f4e4c00 into main Apr 4, 2024
2 checks passed
@sebastianczech sebastianczech deleted the e2e-example branch April 4, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants