feat(acc_test): Adds acceptance testing primitives and test cases #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaspalo
force-pushed
the
feat/accpt-testing-configs
branch
2 times, most recently
from
8215e7f
to
d98f8ed
Compare
jaspalo
changed the title
kklimonda-cl
requested changes
Sep 13, 2024
README.md
Outdated
| # if we have self-signed certificate for a testing instance | ||
| export PANOS_SKIP_VERIFY_CERTIFICATE=true | ||
|
|
||
| # We use either API key or username, password pair for authentication |
There was a problem hiding this comment.
Looks like use of usernames and passwords has an undesired effect of causing tests to fail when executed in parallel? Should we even document that both can be used in that case? Perhaps we need a check in the check function to verify that credentials are not used when parallel > 1 ?
| nameSuffix := acctest.RandStringFromCharSet(6, acctest.CharSetAlphaNum) | ||
| compareValuesDiffer := statecheck.CompareValue(compare.ValuesDiffer()) | ||
|
|
||
| resource.Test(t, resource.TestCase{ |
There was a problem hiding this comment.
All tests seem to be missing CheckDestroy used to verify that resources have actually been removed from the server.
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| ProtoV6ProviderFactories: testAccProviders, | ||
| Steps: []resource.TestStep{ |
There was a problem hiding this comment.
Lets either uncomment this code and fix it, or just drop it from the PR
Adds pango client to the test suite and implements check destroys
jaspalo
force-pushed
the
feat/accpt-testing-configs
branch
from
d98f8ed
to
59d9f46
Compare
kklimonda-cl
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds acceptance testing primitives for Terraform Panos Provider resources and data sources
Motivation and Context
To be sure of the behaviour and predictability of the resources, data sources and other elements enabled by the Panos Terraform provider, we need to verify them through acceptance testing.
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
The changes add primitives and patterns of acceptance testing framework by terraform. Tests covers the following resources:
templateaddress_objectsethernet_interfaceaddress_groupvirtual_routerChecklist
address_objectstests by updating state path traversal.