fix: Fix provider overwriting parts of the resource that is not managed by it #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
changed the title
kklimonda-cl
changed the title
kklimonda-cl
force-pushed
the
feat-sdk-manager
branch
2 times, most recently
from
ef903da
to
3559991
Compare
kklimonda-cl
force-pushed
the
feat-sdk-manager
branch
2 times, most recently
from
cc0557a
to
16d11ac
Compare
kklimonda-cl
force-pushed
the
bug-panos-template-imports
branch
from
88f3a1f
to
f3d387f
Compare
kklimonda-cl
force-pushed
the
feat-sdk-manager
branch
from
16d11ac
to
5d871cf
Compare
kklimonda-cl
force-pushed
the
bug-panos-template-imports
branch
from
f3d387f
to
5bf6c75
Compare
michalbil
approved these changes
Sep 4, 2024
kklimonda-cl
force-pushed
the
bug-panos-template-imports
branch
from
5bf6c75
to
d61ac46
Compare
kklimonda-cl
force-pushed
the
feat-sdk-manager
branch
3 times, most recently
from
79dedac
to
17dddfe
Compare
Private parameters are not part of the schema, but are still managed by terraform.
Some parameters can have codegen override set to skip parameter in terraform provider - this can be used for example when rendering panorama templates to skip attributes related to importing - import is done implicitly when creating other resources. Due to that care has to be taken to make sure those private fields are still copied to pango structures for the update, otherwise Update() call will end up removing them. This implementation follows the old provider, by reading existing entries from the server during Update() call in the provider, and only copying data that is known to the provider, leaving everything else intact.
kklimonda-cl
force-pushed
the
bug-panos-template-imports
branch
from
d61ac46
to
10b22cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During Update() calls make sure fields from the updated entry that are not managed by
terraform are copied from the existing entry, as returned by the server.
Closes: #141
Motivation and Context
Some resource attributes can be marked as private, meaning they are not going to be exposed to users directly. For example, when creating panorama templates, entire import attribute tree is not exposed, as imports are done implicitly based on the location of the import object. This fixes a problem where subsequent terraform apply runs remove entries from the import list.
This however mean, that some of the resource data (private attributes, but also Misc generic XML) have to be somehow restored during Update() calls. This PR creates a very basic implementation that calls Read() during Update() to make sure that we have this data available.
Types of changes