Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two argument ustrip for logarithmic units #535

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gustaphe
Copy link
Contributor

@gustaphe gustaphe commented May 2, 2022

Allows ustrip(u"dB", 3u"B") and ustrip(u"dBV", 1u"dBµV").

No changes to documentation, this feels like expected behavior from the current description of ustrip.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #535 (0daf2a6) into master (960e09e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   88.19%   88.26%   +0.07%     
==========================================
  Files          16       16              
  Lines        1448     1449       +1     
==========================================
+ Hits         1277     1279       +2     
+ Misses        171      170       -1     
Impacted Files Coverage Δ
src/logarithm.jl 78.77% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960e09e...0daf2a6. Read the comment docs.

@sostock sostock added the logarithmic logarithmic scales (decibels, nepers, …) label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logarithmic logarithmic scales (decibels, nepers, …)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants