Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] Fix depthwise conv2d unit test #68388

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

skywalker2012
Copy link
Contributor

@skywalker2012 skywalker2012 commented Sep 23, 2024

PR Category

Custom Device

PR Types

Bug fixes

Description

Aim to fix bad grad check method introduced from #67777,
the original test class inherit from XPUTestConv2DOp and XPUTestConv2DOp_v2, they already have grad check test, so we do not need another one.

@houj04 houj04 added the XPU label Sep 25, 2024
Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 8cd5dcd into PaddlePaddle:develop Sep 25, 2024
26 of 27 checks passed
@skywalker2012 skywalker2012 deleted the fix_depthwise_conv2d branch September 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants