Fix include headers (#365)

* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always * Fix include header, follow IWYU --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
PRBonn · Jul 12, 2024 · 70c3e8d · 70c3e8d
1 parent 5d42087
commit 70c3e8d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/cpp/kiss_icp/core/Preprocessing.cpp b/cpp/kiss_icp/core/Preprocessing.cpp
@@ -26,9 +26,9 @@
 #include <tsl/robin_map.h>
 
 #include <Eigen/Core>
+#include <Eigen/Geometry>
 #include <algorithm>
 #include <cmath>
-#include <sophus/se3.hpp>
 #include <vector>
 
 namespace {

diff --git a/cpp/kiss_icp/core/Preprocessing.hpp b/cpp/kiss_icp/core/Preprocessing.hpp
@@ -23,8 +23,6 @@
 #pragma once
 
 #include <Eigen/Core>
-#include <sophus/se3.hpp>
-#include <utility>
 #include <vector>
 
 namespace kiss_icp {

diff --git a/cpp/kiss_icp/core/Threshold.cpp b/cpp/kiss_icp/core/Threshold.cpp
@@ -22,8 +22,9 @@
 // SOFTWARE.
 #include "Threshold.hpp"
 
-#include <Eigen/Core>
+#include <Eigen/Geometry>
 #include <cmath>
+#include <sophus/se3.hpp>
 
 namespace kiss_icp {
 AdaptiveThreshold::AdaptiveThreshold(double initial_threshold,

diff --git a/cpp/kiss_icp/core/VoxelHashMap.cpp b/cpp/kiss_icp/core/VoxelHashMap.cpp
@@ -24,8 +24,7 @@
 
 #include <Eigen/Core>
 #include <algorithm>
-#include <tuple>
-#include <utility>
+#include <sophus/se3.hpp>
 #include <vector>
 
 namespace kiss_icp {

diff --git a/cpp/kiss_icp/metrics/Metrics.cpp b/cpp/kiss_icp/metrics/Metrics.cpp
@@ -23,6 +23,7 @@
 #include "Metrics.hpp"
 
 #include <Eigen/Core>
+#include <Eigen/Geometry>
 #include <algorithm>
 #include <cassert>
 #include <cmath>