LIB-182: Registration: Add Homeless Checkbox #424
Conversation
|
|
||
| return contactInfoSection; | ||
| } | ||
|
|
There was a problem hiding this comment.
This all looks fine, I guess, but FWIW, I do not think modeling this as a Person Attribute is a good idea. Person Attributes are best used for things that are (ideally unchanging) attributes of a Person. "Is Test Patient". "Eye Color". "Birthplace". These things are set once, just like known attributes like Birthdate, and never (or rarely) changed.
Homeless is (hopefully) a temporary state that a person is in. If they are homeless at the time of registration, we should record that as an Obs on their registration encounter. If we want to see if this has changed over time, we can collect additional answers to this question in subsequent encounters. This would seem a more appropriate way to model this.
@mogoodrich / @lnball ?
There was a problem hiding this comment.
If we keep this as an attribute, code itself looks fine @mogoodrich . But I question whether that's the best way to model this, as I described.
Note there were some tweaks to the registration app module and the ui commons module I needed to make to get this to work, see ticket:
https://pihemr.atlassian.net/browse/LIB-182