PEAR/Functions/FunctionDeclaration: add extra defensive coding

src/Standards/PEAR/Sniffs/Functions/FunctionDeclarationSniff.php

@@ -104,8 +104,9 @@ public function process(File $phpcsFile, $stackPtr)
         // and the opening parenthesis.
         // Unfinished closures are tokenized as T_FUNCTION however, and can be excluded
         // by checking for the scope_opener.
+        $methodProps = $phpcsFile->getMethodProperties($stackPtr);
         if ($tokens[$stackPtr]['code'] === T_FUNCTION
-            && (isset($tokens[$stackPtr]['scope_opener']) === true || $phpcsFile->getMethodProperties($stackPtr)['has_body'] === false)
+            && (isset($tokens[$stackPtr]['scope_opener']) === true || $methodProps['has_body'] === false)
         ) {
             if ($tokens[($openBracket - 1)]['content'] === $phpcsFile->eolChar) {
                 $spaces = 'newline';
@@ -125,25 +126,27 @@ public function process(File $phpcsFile, $stackPtr)
             }
 
             // Must be no space before semicolon in abstract/interface methods.
-            if ($phpcsFile->getMethodProperties($stackPtr)['has_body'] === false) {
+            if ($methodProps['has_body'] === false) {
                 $end = $phpcsFile->findNext(T_SEMICOLON, $closeBracket);
-                if ($tokens[($end - 1)]['content'] === $phpcsFile->eolChar) {
-                    $spaces = 'newline';
-                } else if ($tokens[($end - 1)]['code'] === T_WHITESPACE) {
-                    $spaces = $tokens[($end - 1)]['length'];
-                } else {
-                    $spaces = 0;
-                }
+                if ($end !== false) {
+                    if ($tokens[($end - 1)]['content'] === $phpcsFile->eolChar) {
+                        $spaces = 'newline';
+                    } else if ($tokens[($end - 1)]['code'] === T_WHITESPACE) {
+                        $spaces = $tokens[($end - 1)]['length'];
+                    } else {
+                        $spaces = 0;
+                    }
 
-                if ($spaces !== 0) {
-                    $error = 'Expected 0 spaces before semicolon; %s found';
-                    $data  = [$spaces];
-                    $fix   = $phpcsFile->addFixableError($error, $end, 'SpaceBeforeSemicolon', $data);
-                    if ($fix === true) {
-                        $phpcsFile->fixer->replaceToken(($end - 1), '');
+                    if ($spaces !== 0) {
+                        $error = 'Expected 0 spaces before semicolon; %s found';
+                        $data  = [$spaces];
+                        $fix   = $phpcsFile->addFixableError($error, $end, 'SpaceBeforeSemicolon', $data);
+                        if ($fix === true) {
+                            $phpcsFile->fixer->replaceToken(($end - 1), '');
+                        }
                     }
                 }
-            }
+            }//end if
         }//end if
 
         // Must be one space before and after USE keyword for closures.

src/Standards/PEAR/Tests/Functions/FunctionDeclarationUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error/live coding test.
+// This must be the only test in this file.
+// Safeguarding that the sniff does not throw a PHP notice for this test.
+
+function liveCoding()

src/Standards/PEAR/Tests/Functions/FunctionDeclarationUnitTest.php

@@ -32,8 +32,9 @@ final class FunctionDeclarationUnitTest extends AbstractSniffUnitTest
      */
     public function getErrorList($testFile='')
     {
-        if ($testFile === 'FunctionDeclarationUnitTest.inc') {
-            $errors = [
+        switch ($testFile) {
+        case 'FunctionDeclarationUnitTest.1.inc':
+            return [
                 3   => 1,
                 4   => 1,
                 5   => 1,
@@ -108,8 +109,9 @@ public function getErrorList($testFile='')
                 483 => 1,
                 490 => 2,
             ];
-        } else {
-            $errors = [
+
+        case 'FunctionDeclarationUnitTest.js':
+            return [
                 3  => 1,
                 4  => 1,
                 5  => 1,
@@ -121,9 +123,10 @@ public function getErrorList($testFile='')
                 41 => 1,
                 48 => 1,
             ];
-        }//end if
 
-        return $errors;
+        default:
+            return [];
+        }//end switch
 
     }//end getErrorList()