Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan #139

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix PHPStan #139

merged 1 commit into from
Dec 8, 2023

Conversation

fredden
Copy link
Member

@fredden fredden commented Dec 8, 2023

Description

When I run the test-suite locally, I get errors unless I apply the proposed fixes. Curiously these errors don't seem to be showing up in GitHub - eg https://github.com/PHPCSStandards/PHP_CodeSniffer/actions/runs/7141889620/job/19450040728.

Suggested changelog entry

A changelog entry should not be necessary for this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have verified that the code complies with the projects coding standards.

@fredden fredden marked this pull request as ready for review December 8, 2023 17:54
jrfnl
jrfnl requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredden Happy to accept the PHPStan config change, not the PHPUnit change though.

tests/Core/Ruleset/SetSniffPropertyTest.php Outdated Show resolved Hide resolved
phpstan.neon.dist Show resolved Hide resolved
@jrfnl jrfnl added this to the 3.x Next milestone Dec 8, 2023
@fredden fredden requested a review from jrfnl December 8, 2023 20:17
@jrfnl jrfnl merged commit 9a38a4f into PHPCSStandards:master Dec 8, 2023
32 checks passed
jrfnl pushed a commit that referenced this pull request Dec 8, 2023
@fredden @jrfnl
Fix PHPStan (#139)
7d0b529 
Remove an ignore which is no longer needed since PHPStan 1.10.48.
@jrfnl
Copy link
Member

jrfnl commented Dec 8, 2023

Thanks @fredden !

@jrfnl jrfnl changed the title Fix testsuite Fix PHPStan Dec 8, 2023
@fredden fredden deleted the fix-testsuite branch December 8, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Type: chores/QA
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredden @jrfnl