Merge pull request #600 from PHPCSStandards/feature/generic-lowercase…

…keyword-remove-redundant-targets Generic/LowerCaseKeyword: remove some redundant code
PHPCSStandards · Aug 17, 2024 · 41a426c · 41a426c
2 parents a30d7bd + 59905db
commit 41a426c
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/Standards/Generic/Sniffs/PHP/LowerCaseKeywordSniff.php b/src/Standards/Generic/Sniffs/PHP/LowerCaseKeywordSniff.php
@@ -29,14 +29,10 @@ public function register()
         $targets += [
             T_ANON_CLASS    => T_ANON_CLASS,
             T_CLOSURE       => T_CLOSURE,
-            T_EMPTY         => T_EMPTY,
             T_ENUM_CASE     => T_ENUM_CASE,
-            T_EVAL          => T_EVAL,
-            T_ISSET         => T_ISSET,
             T_MATCH_DEFAULT => T_MATCH_DEFAULT,
             T_PARENT        => T_PARENT,
             T_SELF          => T_SELF,
-            T_UNSET         => T_UNSET,
         ];
 
         return $targets;

diff --git a/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.inc b/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.inc
@@ -48,5 +48,10 @@ new Class {};
 new clasS extends stdClass {};
 new class {};
 
+if (isset($a) && !empty($a)) { unset($a); }
+if (ISSET($a) && !Empty($a)) { UnSeT($a); }
+eval('foo');
+eVaL('foo');
+
 __HALT_COMPILER(); // An exception due to phar support.
 function
diff --git a/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.inc.fixed b/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.inc.fixed
@@ -48,5 +48,10 @@ new class {};
 new class extends stdClass {};
 new class {};
 
+if (isset($a) && !empty($a)) { unset($a); }
+if (isset($a) && !empty($a)) { unset($a); }
+eval('foo');
+eval('foo');
+
 __HALT_COMPILER(); // An exception due to phar support.
 function
diff --git a/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.php b/src/Standards/Generic/Tests/PHP/LowerCaseKeywordUnitTest.php
@@ -50,6 +50,8 @@ public function getErrorList()
             44 => 1,
             47 => 1,
             48 => 1,
+            52 => 3,
+            54 => 1,
         ];
 
     }//end getErrorList()