Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: allow for PHPUnit 8/9 #299

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Dec 8, 2023

PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.

This commit updates the package to take advantage of that.

Includes:

  • Widening the PHPUnit version requirements.
  • Simplifications to the quicktest and test workflows. Also, the code coverage "high" run can now be run against PHP 8.3.
  • Running PHPStan against PHP latest (couldn't previously be done due to the old PHPUnit version).

Not included as this was already handled in this repo:

  • Adding the PHPUnit cache file to .gitignore.
  • Adding various PHPUnit config attributes to ensure deprecation notices and such still show on PHPUnit 9.

Ref:

@jrfnl jrfnl added this to the 1.2.1 milestone Dec 8, 2023
PHP_CodeSniffer 3.8.0 now allows for running the tests, which are based on the PHPCS native test suite, with PHPUnit 8 and 9.

This commit updates the package to take advantage of that.

Includes:
* Widening the PHPUnit version requirements.
* Simplifications to the `quicktest` and `test` workflows.
    Also, the code coverage "high" run can now be run against PHP 8.3.
* Running PHPStan against PHP `latest` (couldn't previously be done due to the old PHPUnit version).

Not included as this was already handled in this repo:
* Adding the PHPUnit cache file to `.gitignore`.
* Adding various PHPUnit config attributes to ensure deprecation notices and such still show on PHPUnit 9.

Ref:
* PHPCSStandards/PHP_CodeSniffer 59
@jrfnl jrfnl force-pushed the feature/start-using-phpunit-8-9 branch from ba5edd6 to deaad9a Compare December 8, 2023 16:20
@jrfnl jrfnl merged commit 52b5b55 into develop Dec 8, 2023
41 checks passed
@jrfnl jrfnl deleted the feature/start-using-phpunit-8-9 branch December 8, 2023 16:31
@jrfnl jrfnl mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant