Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Universal.CodeAnalysis.MixedBooleanOperator #271

Closed
wants to merge 36 commits into from
Closed

Add Universal.CodeAnalysis.MixedBooleanOperator #271

wants to merge 36 commits into from

Commits on Sep 15, 2023

  1. Add Universal.CodeAnalysis.MixedBooleanOperator 

    This is a clone of the proposed sniff in squizlabs/PHP_CodeSniffer#3205. Adding
it to PHPCSExtra to make it generally available quicker than by including it in
core CodeSniffer.
    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6b72184 View commit details
    Browse the repository at this point in the history

  2. Fully qualify constants in MixedBooleanOperatorSniff

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    9414411 View commit details
    Browse the repository at this point in the history

  3. Improve error message in MixedBooleanOperatorSniff

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    cca88c1 View commit details
    Browse the repository at this point in the history

  4. Use BCFile::findStartOfStatement in MixedBooleanOperatorSniff

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b4a8ed0 View commit details
    Browse the repository at this point in the history

  5. Add test with an anonymous function having attributes in MixedBoolean… 

    …OperatorUnitTest
    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0cc2f34 View commit details
    Browse the repository at this point in the history

  6. Extend attribute example for MixedBooleanOperatorUnitTest

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a051300 View commit details
    Browse the repository at this point in the history

  7. Handle curly braces in MixedBooleanOperatorSniff

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    b8c6d30 View commit details
    Browse the repository at this point in the history

  8. Remove unreachability assertions in MixedBooleanOperatorSniff

    @TimWolla
    TimWolla committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ce00faf View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Satisfy PHPStan

    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4a34225 View commit details
    Browse the repository at this point in the history

  2. Add “Not OK” comments to MixedBooleanOperatorUnitTest.inc

    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    1e87cae View commit details
    Browse the repository at this point in the history

  3. Make use of a local search in findPrevious()

    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    8f83191 View commit details
    Browse the repository at this point in the history

  4. Extend test 

    The ternary test currently fails.
    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b713551 View commit details
    Browse the repository at this point in the history

  5. Fix handling of ternaries

    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    54fa62c View commit details
    Browse the repository at this point in the history

  6. Handle all binary boolean operators

    @TimWolla
    TimWolla committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    5c82b55 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Leverage Tokens::$booleanOperators

    @TimWolla
    TimWolla committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    06b47f1 View commit details
    Browse the repository at this point in the history

  2. Report only the first operator if a type within a single expression

    @TimWolla
    TimWolla committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ba07bcf View commit details
    Browse the repository at this point in the history

  3. Update README

    @TimWolla
    TimWolla committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    13e9660 View commit details
    Browse the repository at this point in the history

  4. Clean up implementation

    @TimWolla
    TimWolla committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7a71b8a View commit details
    Browse the repository at this point in the history

  5. Improve naming of the class property

    @TimWolla
    TimWolla committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6f8e5ba View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Drop unused empty error data

    @TimWolla
    TimWolla committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2985f82 View commit details
    Browse the repository at this point in the history

  2. Rename MixedBooleanOperatorSniff::$previousTokens and add docblock

    @TimWolla
    TimWolla committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    20541c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Add if() example to MixedBooleanOperatorStandard.xml

    @TimWolla
    TimWolla committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9df7cd2 View commit details
    Browse the repository at this point in the history

  2. Do not use array_merge()

    @TimWolla
    TimWolla committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    855e932 View commit details
    Browse the repository at this point in the history

  3. Fix codestyle

    @TimWolla
    TimWolla committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    9df244b View commit details
    Browse the repository at this point in the history

  4. Consistentify the error message

    @TimWolla
    TimWolla committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    27f6552 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Hard wrap the error message

    @TimWolla
    TimWolla committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c07507c View commit details
    Browse the repository at this point in the history

  2. Fix formatting in MixedBooleanOperatorStandard.xml

    @TimWolla
    TimWolla committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ecc5bd4 View commit details
    Browse the repository at this point in the history

  3. Fix match arms

    @TimWolla
    TimWolla committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7b38efb View commit details
    Browse the repository at this point in the history

  4. Add additional match tests

    @TimWolla
    TimWolla committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6d84a98 View commit details
    Browse the repository at this point in the history

  5. Add arrow function test

    @TimWolla
    TimWolla committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    14f2d22 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Run composer fixcs

    @TimWolla
    TimWolla committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    9f78b15 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Add additional test

    @TimWolla
    TimWolla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    12ce668 View commit details
    Browse the repository at this point in the history

  2. Rename Sniff

    @TimWolla
    TimWolla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    312beb6 View commit details
    Browse the repository at this point in the history

  3. Reference related sniffs

    @TimWolla
    TimWolla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d152ea7 View commit details
    Browse the repository at this point in the history

  4. Expand documentation

    @TimWolla
    TimWolla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    3126cd6 View commit details
    Browse the repository at this point in the history

  5. Unify @copyright line

    @TimWolla
    TimWolla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    100115b View commit details
    Browse the repository at this point in the history