Skip to content

Commit

Permalink
Fix ApproxDistinctResultVerifier for window fuzzer (facebookincubator…
Browse files Browse the repository at this point in the history
…#10424)

Summary:
Pull Request resolved: facebookincubator#10424

ApproxDistinctResultVerifier expects the number of groups with large
errors to not exceed 5% of the number of all groups. The code
currently instead hardcodes the bound to allow only 3 groups of large
errors. This diff fixes the bound to be 5% * numGroups.

The verification logic for aggregation fuzzer works fine so far, so this
diff doesn't update the bound for aggregation fuzzer.

Reviewed By: Yuhta

Differential Revision: D59530860

fbshipit-source-id: ae9324bc72491a1a87e19893773088c654322890
  • Loading branch information
kagamiori authored and facebook-github-bot committed Jul 9, 2024
1 parent bc5a813 commit 836bb30
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class ApproxDistinctResultVerifier : public ResultVerifier {

// We expect large deviations (>2 stddev) in < 5% of values.
if (numGroups >= 50) {
return largeGaps.size() <= 3;
return largeGaps.size() <= 0.05 * numGroups;
}

return largeGaps.empty();
Expand Down

0 comments on commit 836bb30

Please sign in to comment.