Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for .net8 #48

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Updates for .net8 #48

merged 4 commits into from
Jan 18, 2024

Conversation

Kritner
Copy link
Member

@Kritner Kritner commented Jan 18, 2024

Description

  • Update to .net8
  • Nullable reference types
  • Adds central package versioning

Fixes # (issue number)
#47

Type of Change

Use an x in between the [ ] for each line applicable to the type of change for this PR

  • Bug fix
  • New Feature
  • Documentation
  • Code improvement
  • Breaking change - if a public API changes, or any change that DOES or MAY require a major revision to the NuGet package version due to semver.
  • Unit tests
  • Code samples
  • Added your repository URL to the readme because you make use of this super cool package! ;)
  • Other

Please describe if other

Describe testing that was performed for your change

Ran unit tests, was getting a failure locally, but attributing that hopefully to my m1, want to see what the pipeline does

Checklist

@Kritner Kritner mentioned this pull request Jan 18, 2024
@Kritner Kritner added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2024
@Kritner Kritner marked this pull request as ready for review January 18, 2024 11:51
@Kritner Kritner merged commit 525fed3 into main Jan 18, 2024
3 checks passed
@Kritner Kritner deleted the feature/47/dotnet8 branch January 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant