Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade projects to dotnet8 #71

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

vader1986
Copy link
Contributor

@vader1986 vader1986 commented Dec 12, 2023

Closes: #70

@galvesribeiro
Copy link
Member

Thanks @vader1986!

Copy link
Member

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvesribeiro galvesribeiro merged commit 8e72e69 into OrleansContrib:master Dec 12, 2023
2 checks passed
@turowicz
Copy link

you didnt update the package references that still point to 7.x @vader1986 @galvesribeiro

@vader1986
Copy link
Contributor Author

My understanding was that Orleans 8 is not released yet (only a rc). I can add another PR to upgrade other packages (Microsoft.Extensions.*) if you like?

@turowicz
Copy link

turowicz commented Dec 12, 2023

You can either upgrade them to 8.0-rc1 or you could just mark them as private assets so nuget doesnt install them automatically and they don't appear as dependencies.

image

@vader1986
Copy link
Contributor Author

You can either upgrade them to 8.0-rc1 or you could just mark them as private assets so nuget doesnt install them automatically and they don't appear as dependencies.

image

#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 8.0 please
3 participants