ON-876: reviewing ERC-7589 interface #173
ernanirstAnnotations
10 errors and 1 warning
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L25
'lockId' is never reassigned. Use 'const' instead
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L130
Replace `⏎········ERC7589RolesRegistry.connect(owner).setMarketplaceAddress(anotherUser.address),⏎······` with `ERC7589RolesRegistry.connect(owner).setMarketplaceAddress(anotherUser.address)`
|
|
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L175
Replace `⏎··········lockId,⏎··········ROLE,⏎··········recipient.address,⏎··········expirationDate,⏎··········false,⏎··········HashZero,⏎········` with `lockId,·ROLE,·recipient.address,·expirationDate,·false,·HashZero`
|
|
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L220
Replace `⏎········ERC7589RolesRegistry.connect(owner).revokeRole(lockId,·ROLE,·recipient.address),⏎······).to.be.revertedWith('ERC7589RolesRegistry:·role·is·not·revocable·or·caller·is·not·the·approved'` with `ERC7589RolesRegistry.connect(owner).revokeRole(lockId,·ROLE,·recipient.address)).to.be.revertedWith(⏎········'ERC7589RolesRegistry:·role·is·not·revocable·or·caller·is·not·the·approved',⏎······`
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L229
Replace `⏎········ERC7589RolesRegistry.revokeRole(lockId,·ROLE,·recipient.address),⏎······).to.be.revertedWith('ERC7589RolesRegistry:·role·does·not·exist'` with `ERC7589RolesRegistry.revokeRole(lockId,·ROLE,·recipient.address)).to.be.revertedWith(⏎········'ERC7589RolesRegistry:·role·does·not·exist',⏎······`
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L239
Replace `⏎········ERC7589RolesRegistry.revokeRole(lockId,·ROLE,·recipient.address),⏎······).to.be.revertedWith('ERC7589RolesRegistry:·role·does·not·exist'` with `ERC7589RolesRegistry.revokeRole(lockId,·ROLE,·recipient.address)).to.be.revertedWith(⏎········'ERC7589RolesRegistry:·role·does·not·exist',⏎······`
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L252
Replace `MockErc1155Token.address,·anotherUser.address,·true` with `⏎··········MockErc1155Token.address,⏎··········anotherUser.address,⏎··········true,⏎········`
|
|
build_test_deploy:
test/ERC7589/ERC7589RolesRegistry.spec.ts#L254
Replace `⏎········ERC7589RolesRegistry.connect(anotherUser).revokeRole(lockId,·ROLE,·recipient.address),⏎······` with `ERC7589RolesRegistry.connect(anotherUser).revokeRole(lockId,·ROLE,·recipient.address)`
|
|
build_test_deploy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|