Update ID and URL paths to use full city name and state two letter code #57
Conversation
Basically just future proofing. Also copying all paths for legacy support just in case.
| @@ -97,18 +97,18 @@ func (c *Client) SeattleOfficerMetadata() *DepartmentMetadata { | |||
| }, | |||
| LastAvailableRosterDate: date.Format("2006-01-02"), | |||
| Name: "Seattle PD", | |||
| ID: "spd", | |||
| ID: "seattle-wa", | |||
There was a problem hiding this comment.
I'm pretty sure we'll also need to update 1-312 with this new ID here: https://github.com/OrcaCollective/1-312-hows-my-driving/blob/main/src/app.py#L106
|
This should maintain backwards compatibility for the existing endpoints and... I'm pretty sure it works with 1-312 with no update but I would have to look again to explain exactly why. |
|
That metadata is pulled from |
|
FYI the departments metadata return got updated here so it should propagate out to the website. Even if it doesn't I have the old endpoints down at the bottom of the router file just in case anyone is using this. E.g.: And: |
Closes #33
Basically just "future proofing."
All existing paths copied for legacy support.
Tested with current version of 1-312-hows-my-driving to confirm that the website continues to work as intended. Please be sure to validate but couldn't find any issues.