Prevent harmful usage of defaults.Set() (#233)

OpsLevel · Jan 5, 2024 · 165b10b · 165b10b
1 parent f66d7cc
commit 165b10b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/.changes/unreleased/Bugfix-20240105-154208.yaml b/.changes/unreleased/Bugfix-20240105-154208.yaml
@@ -0,0 +1,3 @@
+kind: Bugfix
+body: Fix bug in Infra where unexpected data would be included in requests
+time: 2024-01-05T15:42:08.827698-05:00
diff --git a/src/cmd/check.go b/src/cmd/check.go
@@ -6,7 +6,6 @@ import (
 
 	"github.com/opslevel/opslevel-go/v2023"
 
-	"github.com/creasty/defaults"
 	"github.com/opslevel/cli/common"
 	"github.com/rs/zerolog/log"
 	"github.com/spf13/cobra"
@@ -466,8 +465,5 @@ func readCheckInput() (*CheckInputType, error) {
 	// Unmarshall
 	evt := &CheckInputType{}
 	viper.Unmarshal(&evt)
-	if err := defaults.Set(evt); err != nil {
-		return nil, err
-	}
 	return evt, nil
 }
diff --git a/src/cmd/infra.go b/src/cmd/infra.go
@@ -8,7 +8,6 @@ import (
 	"os"
 	"strings"
 
-	"github.com/creasty/defaults"
 	"github.com/opslevel/cli/common"
 	"github.com/opslevel/opslevel-go/v2023"
 	"github.com/rs/zerolog/log"
@@ -249,8 +248,5 @@ func readInfraInput() (*opslevel.InfraInput, error) {
 	cobra.CheckErr(err)
 	evt := &opslevel.InfraInput{}
 	cobra.CheckErr(yaml.Unmarshal(file, &evt))
-	if err := defaults.Set(evt); err != nil {
-		return nil, err
-	}
 	return evt, nil
 }