Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-shell): fix clearing robot update cache after robot cache update #16706

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(app-shell): fix clearing robot update cache after robot cache update #16706

merged 1 commit into from
Nov 6, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 6, 2024 •
edited
Loading

Closes EXEC-806

Overview

Fixes a bug related to clearing the robot update cache after a robot cache update. Woops, we were checking inside the directory of the current version for other version directories instead of in the parent directory itself.

Untitled.mov

Occurs on app open and after new robot cache file downloaded.

Test Plan and Hands on Testing

  • Made a custom build of the app based on 8.1.0 with this branch. You can download it here if you want to test it yourself.
  • Opened the app. See video. Confirmed this also deleted the stale OT-2 cache files.

Changelog

  • The desktop app now clears stale robot update version cache files.

Risk assessment

low

@mjhuff mjhuff requested a review from sfoster1 November 6, 2024 17:43
@mjhuff mjhuff requested a review from a team as a code owner November 6, 2024 17:43
@mjhuff mjhuff requested review from smb2268 and removed request for a team November 6, 2024 17:43
@mjhuff mjhuff marked this pull request as draft November 6, 2024 17:44
sfoster1
sfoster1 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. whoops. why is that a global aahhh

@mjhuff mjhuff changed the title fix(app-shell): fix clearing robot update cache after app update fix(app-shell): fix clearing robot update cache after robot cache update Nov 6, 2024
@mjhuff mjhuff marked this pull request as ready for review November 6, 2024 18:35
@mjhuff mjhuff merged commit 0ad9ef8 into chore_release-8.2.0 Nov 6, 2024
31 checks passed
@mjhuff mjhuff deleted the app-shell_fix-robot-cache-clearing branch November 6, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@smb2268 smb2268 Awaiting requested review from smb2268 smb2268 is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjhuff @sfoster1