Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): deleting staging area also deletes 4th colum… #16701

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 6, 2024

…n labware

closes RQA-3522 RQA-3467

Overview

Now there is a warning modal when you delete a staging area with a labware in column 4 letting you know that the labware will also be deleted

Test Plan and Hands on Testing

Test the 3 entry points for the warning modal rendering:
1.0 testing.json

  1. deleting the staging area from the "clear slot" overflow menu button
  2. deleting the staging area from the "clear" button in the toolbox when zoomed in on the staging area slot
  3. changing the radio button to a different button

NOTE: liquids disappear when zoomed in on a slot, that is a different bug i'll tackle in a followup

Changelog

  • create modal
  • add logic to the 3 entry points
  • fix up some logic for when the 4th column labware renders when zoomed in

Risk assessment

low

@jerader jerader requested a review from a team as a code owner November 6, 2024 14:01
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as expected

@koji koji added the authorship label Nov 6, 2024
@jerader jerader merged commit f66ffb9 into edge Nov 6, 2024
12 checks passed
@jerader jerader deleted the pd_fix-staging-area-weirdness branch November 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants