Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer, components): clean up a bunch of warnings in console #16664

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 1, 2024

closes RQA-3357

Overview

Clean up a bunch of warnings in console

Test Plan and Hands on Testing

Go through PD and check console and see that most warnings are gone (there is a warning with going to onboarding that i kept for now + the mixpanel warning)

Changelog

  • fix some usages of styled
  • add some keys
  • remove nested <p> tags
  • replace grigGap with gridGap
  • fix some props
  • fix some typos

Risk assessment

low

@jerader jerader requested review from a team as code owners November 1, 2024 15:01
@jerader jerader requested review from shlokamin and removed request for a team November 1, 2024 15:01
@jerader jerader requested a review from koji November 1, 2024 17:51
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
thank you for doing this!

@jerader jerader merged commit d7a6221 into edge Nov 1, 2024
56 checks passed
@jerader jerader deleted the pd_fix-warnings branch November 1, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants