-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer, components): clean up a bunch of warnings in console #16664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Nov 1, 2024
jerader
commented
Nov 1, 2024
koji
reviewed
Nov 1, 2024
components/src/atoms/ListButton/ListButtonChildren/ListButtonRadioButton.tsx
Outdated
Show resolved
Hide resolved
jerader
force-pushed
the
pd_fix-warnings
branch
from
November 1, 2024 15:12
a9e1b00
to
8702b0d
Compare
koji
reviewed
Nov 1, 2024
koji
reviewed
Nov 1, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/Timeline/StepContainer.tsx
Show resolved
Hide resolved
koji
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
thank you for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3357
Overview
Clean up a bunch of warnings in console
Test Plan and Hands on Testing
Go through PD and check console and see that most warnings are gone (there is a warning with going to onboarding that i kept for now + the mixpanel warning)
Changelog
styled
<p>
tagsgrigGap
withgridGap
Risk assessment
low