Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): add cornerOffsetFromSlot to deck riser #16622

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Oct 29, 2024

Overview

The client was not able to render the deck riser correctly because it was offset by -6.125mm, this is because the cornerOffsetFromSlot was missing from the definition. This pull request adds this offset as measured by the hardware team. The value is negative because the deck riser top lip is larger than the slot it sits on.

Test Plan and Hands on Testing

  • Make sure we can move TC lids with the gripper
  • Make sure we can pipette into TC lids
  • Make sure the deck riser is visually aligned on the deck map view.

Changelog

  • add -6.125mm x and y cornerOffsetFromSlot to the deck riser adaptor definition.

Review requests

Risk assessment

low

@vegano1 vegano1 requested a review from a team as a code owner October 29, 2024 12:45
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. And this is render only?

@vegano1
Copy link
Contributor Author

vegano1 commented Oct 29, 2024

Weird. And this is render only?

it is most obvious in the render since we use cornerOffsetFromSlot to center the geometry.
However, we also use cornerOffsetFromSlot when calculating the well position for pipetting.
The riser was tested with TC lids, which we don't pipette out of, however the riser could be used with other labware in the future.

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@vegano1 vegano1 merged commit 82cb47b into edge Oct 29, 2024
73 checks passed
@vegano1 vegano1 deleted the add-corner-offsets-from-slot-to-deck-riser branch October 29, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants