fix(shared-data): add cornerOffsetFromSlot to deck riser #16622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The client was not able to render the deck riser correctly because it was offset by -6.125mm, this is because the
cornerOffsetFromSlot
was missing from the definition. This pull request adds this offset as measured by the hardware team. The value is negative because the deck riser top lip is larger than the slot it sits on.Test Plan and Hands on Testing
Changelog
cornerOffsetFromSlot
to the deck riser adaptor definition.Review requests
Risk assessment
low