refactor(api): Delete dead private_result supporting code
#16621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Oct 29, 2024
|
Yeah I’ll rebase and merge into edge behind #16620. |
SyntaxColoring
force-pushed
the
the_righteous_have_nothing_to_hide
branch
from
93b408d
to
4b5b11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#16620 deletes the last uses of
SucceedCommandAction.private_result. (It is replaced bySucceedCommandAction.state_update.)This PR deletes the attribute and the remaining code that was using it.
Test Plan and Hands on Testing
Just CI.
Review requests
This is basically just a few global find+replace operations. I've gone through the diff to make sure there was no collateral damage, but maybe you want to skim it too to double-check me.
Risk assessment
Low.