-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): add schema 3 versions of json files with inner labware geometry #16618
Conversation
d348e2b
to
31506c7
Compare
0f77f30
to
555dcab
Compare
555dcab
to
bcaf976
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It makes me feel a little weird to have the geometry definition references just be like "a"
though - maybe we can call those "main" or a uuid or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once we fix CI
Overview
This takes the physical measurements the hardware team did and adds it to the json data. Will continue to flesh this out as more labware are tested and verified.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment