Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer) add screen too small overlay #16604

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat(protocol-designer) add screen too small overlay #16604

merged 2 commits into from
Oct 25, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 24, 2024

Overview

add screen too small overlay

too_small_screen.mov

close AUTH-849

Test Plan and Hands on Testing

resize the window's size
width: less than 600px
height: less than 650px

Changelog

  • add DisabledScreen component and its test
  • add useScreenSizeCheck and its test

Review requests

low

Risk assessment

@koji koji marked this pull request as ready for review October 24, 2024 22:50
@koji koji requested a review from a team as a code owner October 24, 2024 22:50
@koji koji requested a review from a team as a code owner October 24, 2024 23:17
jerader
jerader approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 lgtm!

@koji koji merged commit a9f4701 into edge Oct 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji @jerader