fix(scripts): make aws deploy scripts work with new sdk #16586
Merged
+42
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
changed the title
shlokamin
changed the title
shlokamin
changed the title
jerader
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After #15267 merged which updated the aws sdk from 2 to 3 our web deploy scripts stopped working for staging and production releases. This PR updates our scripts to use v3 of the aws sdk (hopefully correctly).
I verified that staging promotions work, and production should work too but I'm not gonna do a prod release right now.
closes AUTH-979
Review requests
Risk assessment
Medium