fix(protocol-designer): preserve uppercase letters of step name #16584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syao1226
changed the title
koji
reviewed
Oct 24, 2024
| @@ -322,3 +322,6 @@ export const getSaveStepSnackbarText = ( | |||
| return t(`protocol_steps:save_no_errors`, { stepType: stepTypeDisplayName }) | |||
| } | |||
| } | |||
|
|
|||
| export const capitalizeFirstLetter = (stepName: string): string => | |||
| stepName.charAt(0).toUpperCase() + stepName.slice(1) | |||
There was a problem hiding this comment.
nit
`${stepName.charAt(0).toUpperCase()}${stepName.slice(1)}`
koji
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Could you add tests for capitalizeFirstLetter?
koji
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes RQA-3398
Overview
Fixes the issue where renaming a step name with uppercase characters caused everything after the first character to be lowercased.
Test Plan and Hands on Testing
Changelog
capitalizeFirstLetter()toStepForm/utilsto capitalize onlt the first character while leaving the rest of the string unchangedReview requests
Risk assessment