-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): home all gripper axis when a stall is detected #16579
fix(api): home all gripper axis when a stall is detected #16579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but maybe a name for the error code?
return chainRunRecoveryCommands([HOME_GRIPPER_Z_AXIS]) | ||
const homeGripper = useCallback((): Promise<CommandData[]> => { | ||
const gripperAxis = | ||
failedCommandByRunRecord?.error?.errorCode === '2003' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get a name for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Just one comment to think about.
const gripperAxis = | ||
failedCommandByRunRecord?.error?.errorCode === '2003' | ||
? HOME_GRIPPER | ||
: HOME_GRIPPER_Z_AXIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO Because we conditionally call this command only during gripper recovery anyway, I'd be down just to always HOME_GRIPPER
. That may be easier and reduce the bug surface a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me!
Overview
fix for https://opentrons.atlassian.net/browse/RQA-3390.
when a
move_labware
fails on a stall/collision its position is unknowen.we currently home just the gripper z, this pr homes
extensionZ
andupdatePositionEstimators
collision is detected.Test Plan and Hands on Testing
steps are in the ticket. I used this protocol to reproduce:
Changelog
home gripper z and updatePositionEstimators.
Review requests
are we good with chaining it? do we want to split it to 2 separate methods?
Risk assessment
low.