Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Add gripper release animation to Error Recovery #16575

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat(app): Add gripper release animation to Error Recovery #16575

merged 2 commits into from
Oct 23, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 23, 2024 •
edited by jira bot
Loading

Closes EXEC-790

Overview

By audience demand:

Screen.Recording.2024-10-23.at.9.44.36.AM.mov

Test Plan and Hands on Testing

  • See video. Verified it looks correct on the ODD, too.

Changelog

  • Added the gripper release animation to gripper Error Recovery.

Risk assessment

low

@mjhuff mjhuff requested a review from a team October 23, 2024 14:19
@mjhuff mjhuff requested a review from a team as a code owner October 23, 2024 14:19
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 October 23, 2024 14:19
sfoster1
sfoster1 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the labware just falling away

@mjhuff mjhuff merged commit 2b7201d into edge Oct 23, 2024
6 checks passed
@mjhuff mjhuff deleted the app_gripper-release-animation-er branch October 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjhuff @sfoster1