feat(app): implement ODD choose language screen, app language toggles #16573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the choose language screen that will be the first step of the ODD unboxing flow. migration of the unboxing flow route config value from '/welcome' to '/choose-langauge' will happen in a future PR removing the localization feature flag. closes PLAT-537
brenthagen
requested review from
jerader
and removed request for
a team and
jerader
brenthagen
commented
Oct 23, 2024
brenthagen
commented
Oct 23, 2024
adds the desktop app dropdown menu to choose language on the app settings general tab closes PLAT-507
brenthagen
changed the title
adds the ODD language setting toggle to the robot settings page closes PLAT-506
brenthagen
changed the title
sfoster1
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
implements the choose language screen that will be the first step of the ODD unboxing flow. migration of the unboxing flow route config value from '/welcome' to '/choose-langauge' will happen in a future PR removing the localization feature flag.
the screen can be tested locally by manually editing
unfinishedUnboxingFlowRouteinconfig.jsonand commenting out the linedev-shell-odd: export OT_APP_ON_DEVICE_DISPLAY_SETTINGS__UNFINISHED_UNBOXING_FLOW_ROUTE := 0in the app makefile.implements the language setting hi-fi designs on desktop and ODD.
closes PLAT-537, PLAT-506
Test Plan and Hands on Testing
added unit tests for the screen and toggles, verified all behavior
Changelog
Review requests
check out the screens and toggles
Risk assessment
low, screen not active until config migrated, toggles behind feature flag