feat(shared-data): add transitional shape calculations #16554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Oct 22, 2024
ryanthecoder
force-pushed
the
EXEC-712-add-transitional-shape
branch
from
f12cfa6
to
a11fa6b
Compare
sfoster1
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a cached property to the "Squared cone" labware geometry segment that computes the height/volume tables if needed.
Also update frustum helpers to use these and don't raise a Not implemented error on this shape.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment