docs(api): fixes to protocol examples #16545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While going through, noticed some typos
ecormany
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks for spotting these! The mount standardization is just nice to have, but that scoping error in the dilution protocol really changed the intended effect. Sneaky too, because that code passes simulation.
I'm going to touch up the PR title and tags so this doesn't get lost if we need to refer back to it in the future.
ecormany
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed minor typos in api/docs/v2/new_examples.rst
Overview
Test Plan and Hands on Testing
No need testing
Closes AUTH-963
Changelog
Review requests
Look at the changes please
Risk assessment
Low