feat(opentrons-ai-client): Header component with progressbar #16543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connected-znaim
changed the title
connected-znaim
requested review from
koji,
y3rsh,
shlokamin,
Elyorcv and
fbelginetw
shlokamin
reviewed
Oct 21, 2024
There was a problem hiding this comment.
will our progress bar component not work for this? https://s3-us-west-2.amazonaws.com/opentrons-components/edge/index.html?path=/docs/app-atoms-progressbar--docs
|
similar issue with the progressbar for the header with meter PR. It is sitting in app/src/atoms |
shlokamin
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added a progressbar to the header component:
Test Plan and Hands on Testing
Manually added in different values for the prop to ensure it works from 0-1
Changelog
Review requests
Risk assessment