Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix slots availability functions to support multiple modules #16541

Closed
wants to merge 5 commits into from

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 19, 2024

Overview

fix slots availability functions for multiple modules

fyi there is a DQA ticket for item alignment (dropdown menu and text) but this PR doesn't fix that since the PR focuses on fixing module add logic.

close RQA-3324

Test Plan and Hands on Testing

  1. click create a new protocol
  2. select Flex
  3. select a pipette/pipettes
  4. add modules

Step 4 needs to check a few patterns

check 1. when adding Heater Shaker module or Temperature module (just one), quantity displays 1-7
check 2. when adding Magnetic Block, quantity displays 1-11
check 3. when adding Heater Shaker module and Temperature module (just one), each of quantity displays 1-6
check 4. when adding Heater Shaker module/Temperature module/TC + Magnetic Block, each quantity displays correct number. In this case, the available slots are 11 not 7
ex HS 7 -> MB displays 1-4
ex HS 2 -> MB displays 1-9
check 5. do the case Skye in the ticket - add Heater Shaker module and Temperature module then modify the quantity to be the total is 7. Then add Magnetic Block. no snack bar.
check 6. add TC module, Heater Shaker module and Temperature module then modify the quantity to be the total is 7.
check 7. do one of the above cases and click remove button, then check quantity options are correct

Changelog

Review requests

Risk assessment

low since the changes for only SelectModules component

…modules

fix slots availablity functions for multiple modules

close RQA-3324
@koji
Copy link
Contributor Author

koji commented Oct 19, 2024

  • fix module card re-ordering issue <- followed by another PR
  • clean up code and fix check-js and lint-js error

@koji koji changed the title fix(protocol-designer): fix slots availablity functions to support multiple modules fix(protocol-designer): fix slots availability functions to support multiple modules Oct 19, 2024
@koji koji marked this pull request as ready for review October 21, 2024 15:57
@koji koji requested a review from a team as a code owner October 21, 2024 15:57
@koji koji removed the request for review from a team October 21, 2024 16:08
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don't seem to be getting a quantity dropDown for any modules except Temperature

@koji
Copy link
Contributor Author

koji commented Oct 21, 2024

Hm, I don't seem to be getting a quantity dropDown for any modules except Temperature

just merged the edge for removing ff, so you will be able to see multiple modules.

@koji
Copy link
Contributor Author

koji commented Oct 30, 2024

This will be covered by Jethary's PR #16642

@koji koji closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants