fix(protocol-designer): fix slots availability functions to support multiple modules #16541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix slots availability functions for multiple modules
fyi there is a DQA ticket for item alignment (dropdown menu and text) but this PR doesn't fix that since the PR focuses on fixing module add logic.
close RQA-3324
Test Plan and Hands on Testing
Step 4 needs to check a few patterns
check 1. when adding Heater Shaker module or Temperature module (just one), quantity displays
1-7
check 2. when adding Magnetic Block, quantity displays
1-11
check 3. when adding Heater Shaker module and Temperature module (just one), each of quantity displays
1-6
check 4. when adding Heater Shaker module/Temperature module/TC + Magnetic Block, each quantity displays correct number. In this case, the available slots are
11
not7
ex HS 7 -> MB displays 1-4
ex HS 2 -> MB displays 1-9
check 5. do the case Skye in the ticket - add Heater Shaker module and Temperature module then modify the quantity to be the total is 7. Then add Magnetic Block. no snack bar.
check 6. add TC module, Heater Shaker module and Temperature module then modify the quantity to be the total is
7
.check 7. do one of the above cases and click remove button, then check quantity options are correct
Changelog
Review requests
Risk assessment
low since the changes for only SelectModules component