refactor(app): Refactor display name utils

[mjhuff]

Closes EXEC-773

Overview

Now that we have a definitive locations for general app utils, all general utilities should now be imported through places like local-resources and not from the internals of component directories. One of the biggest culprits of violating this rule is Commands. We use a lot of these utilities elsewhere.

This PR serves as a general refactor for display name utils, which entails:

• Migrating them to local-resources
• Tightening the interfaces. More specifically, instead of passing all of protocolAnalysis, pass only what we need.
• The above has the added benefit of highlighting potential problem parameters, ie, commands. I actually caught a couple more unnecessary cases of iterating through protocolAnalysis, so this refactor reduces TC by O(2n) in some spots.
• The above also enforces stricter typing - there are actually a couple spots that could cause whitescreens on older protocols, because we weren't properly typechecking protocolAnalysis before attempting to iterate through modules or labware when it could in fact be an object and not an array. I guess in practice, this probably doesn't happen much, since I've personally never seen any tickets about this.

04b6ad3 Contains the functional changes.

d350e0d is just a million lint/test fixes.

Test Plan and Hands on Testing

• Smoke tested runs. Everything looks good.

Risk assessment

lowish-medium.

[sfoster1]

We know we're in a good place when we're using Array.isArray

Good finds on removing more command iteration!

[TamarZanzouri]

added by mistake?

[mjhuff]

No, it's intentional.

This is documented somewhere on confluence, but generally we have a pattern in the monorepo for js import order:

1. Global imports
2. Top-level monorepo imports
3. Local imports
4. Types

These should be separated by a space.

[TamarZanzouri]

WOW! so much better! 1 unintentional change but besides that looks great