refactor(app): update various error recovery copy/css #16519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
jerader
and removed request for
a team and
jerader
sfoster1
approved these changes
Oct 18, 2024
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
Closes EXEC-776 This commit is a hodgepodge of small refactors to update error recovery to match designs (and fix small things that bother me and probably no one else). b98064d - Updates the drop tip wizard copy to match designs e8ff83f - If you look at "go back" and "continue" buttons, they aren't actually aligned. I think I borked this recently. 041305e - The deck map in ER slightly pushes down the "continue" button so it's not perfectly aligned with other error recovery "continue" buttons. This fixes that. beb4184 - If you click "view error details" on the desktop app and adjust the size of your app, eventually the error details modal doesn't align with error recovery. Let's fix this by giving InterventionModal the same padding styling as the basic modal, which it should probably have regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-776
Overview
This PR is a hodgepodge of small refactors to update error recovery to match designs (and fix small things that bother me and probably no one else).
b98064d - Updates the drop tip wizard copy to match designs
e8ff83f - If you look at "go back" and "continue" buttons, they aren't actually aligned. I think I borked this recently.
041305e - The deck map in ER slightly pushes down the "continue" button so it's not perfectly aligned with other error recovery "continue" buttons. This fixes that.
beb4184 - If you click "view error details" on the desktop app and adjust the size of your app, eventually the error details modal doesn't align with error recovery. Let's fix this by giving
InterventionModalthe same padding styling as the basic modal, which it should probably have regardless.Risk assessment
low