feat(app): Add Error Recovery support for in-place commands #16515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
smb2268
and removed request for
a team and
smb2268
sfoster1
approved these changes
Oct 17, 2024
| } as RunTimeCommand) | ||
| expect(result).toEqual(ERROR_KINDS.OVERPRESSURE_WHILE_DISPENSING) | ||
| IS_IN_PLACE.forEach(isInPlace => { | ||
| it(`returns ${ERROR_KINDS.OVERPRESSURE_WHILE_ASPIRATING} for ${DEFINED_ERROR_TYPES.OVERPRESSURE} errorType when using the inPlace command type is ${isInPlace}`, () => { |
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
Closes EXEC-777 #16510 appears to have fixed most of the inPlace issues we had seen back in 8.0, and it has (hopefully) greatly simplified the additional support the app needs to provide to get inPlace variations of aspirate/dispense working. This commit just wires up those commands to the appropriate flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-777
Overview
#16510 appears to have fixed most of the
inPlaceissues we had seen back in 8.0, and it has (hopefully) greatly simplified the additional support the app needs to provide to getinPlacevariations ofaspirate/dispenseworking.This PR just wires up those commands to the appropriate flows.
Test Plan and Hands on Testing
dispenseInPlaceusing this protocol.in_place.json
Changelog
aspirateInPlaceanddispenseInPlaceto the appropriate Error Recovery flows.Risk assessment
low