feat(protocol-designer): magnetic module change hint wire up #16498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
reviewed
Oct 21, 2024
protocol-designer/src/organisms/BlockingHintModal/__tests__/BlockingHintModal.test.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 21, 2024
protocol-designer/src/organisms/BlockingHintModal/__tests__/BlockingHintModal.test.tsx
Show resolved
Hide resolved
koji
reviewed
Oct 21, 2024
protocol-designer/src/organisms/BlockingHintModal/__tests__/BlockingHintModal.test.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 21, 2024
protocol-designer/src/organisms/BlockingHintModal/__tests__/BlockingHintModal.test.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 21, 2024
koji
reviewed
Oct 21, 2024
koji
reviewed
Oct 21, 2024
koji
reviewed
Oct 21, 2024
koji
reviewed
Oct 21, 2024
protocol-designer/src/pages/Designer/DeckSetup/MagnetModuleChangeContent.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 21, 2024
protocol-designer/src/pages/Designer/DeckSetup/__tests__/MagnetModuleChangeContent.test.tsx
Show resolved
Hide resolved
|
seems that there was copy update. |
jerader
force-pushed
the
pd_blocking-hint
branch
from
47950e1
to
0ae5253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-797
Overview
wires up the hint when you change between a gen1 vs gen2 or vice versa for magnetic modules
NOTE: there are a bunch of z-index issues we have to fix at some point (with the toolboxes and modals), we can fix those all together later on
Test Plan and Hands on Testing
Create an ot-2 protocol and add a magnetic module gen 1. Then change it to a magnetic module gen2. the hint modal should pop up. try checking the checkbox and cancel or continue. the hint should only pop up only once (but if you reimport it, it should pop up again unless permanently dismissed)
Changelog
Risk assessment
low