feat(app): Plate reader in LPC and CommandText, filter out plate reader lid as labware #16489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
changed the title
smb2268
requested review from
brenthagen,
ecormany and
vegano1
and removed request for
a team
ecormany
reviewed
Oct 15, 2024
vegano1
reviewed
Oct 15, 2024
| @@ -1,4 +1,8 @@ | |||
| { | |||
| "absorbance_reader_open_lid": "Opening Absorbance Reader lid", | |||
| "absorbance_reader_close_lid": "Closing Absorbance Reader lid", | |||
| "absorbance_reader_initialize": "Initializing Absorbance Reader to perform {{mode}} measurement at {{wavelengths}}", | |||
There was a problem hiding this comment.
Hmm, can't hurt. We would tack on with reference of {{referenceWavelength}} nm
vegano1
reviewed
Oct 15, 2024
| @@ -46,7 +46,7 @@ export const AbsorbanceReaderData = ( | |||
| data-testid="abs_module_data" | |||
| > | |||
| {t('abs_reader_lid_status', { | |||
| status: moduleData.lidStatus === 'on' ? 'open' : 'closed', | |||
| status: moduleData.lidStatus === 'on' ? 'closed' : 'open', | |||
vegano1
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PLAT-483, PLAT-525, PLAT-526, PLAT-547, RQA-3310
Overview
This PR cleans up a few things for plate reader support in the UI, enables LPC, hides the labware lid from protocol setup and details, and wires up command text
Test Plan and Hands on Testing
Reviewed the following locations to make sure plate reader lid does not display:
Looked at run preview for protocol that uses absorbance reader, view command text updates
Ran LPC for protocol that uses absorbance reader
Changelog
Review requests
Look over screenshots and command types
Risk assessment
Low