Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Wire up door status affordances for gripper error flows #16487

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 15, 2024

Closes EXEC-723

Overview

This PR closes out the gripper flows by adding the expected gripper behavior given the door status. These affordances include proper jaw release while the door is open, ensuring the door is closed before z-homing the gripper, implicitly z-homing the gripper if the door is already closed after releasing labware.

There's some minor refactoring here as well. Copy for gripper flows was recently updated, so some views are refactored to handle different copy depending on the selectedRecoveryOption.

The major challenge here is thinking through all the permutations of gripper/door state behavior. One of the trickier aspects is implicitly executing fixit commands, since most commands up to this point are directly tied to a CTA. We have a semi-pattern for this useInitialPipette. If we do more implicit fixit command behavior, it will probably be worth spending the time to think through how to elucidate this implicit behavior a bit better, since the control flow is dense.

There is one follow-up ticket to this: EXEC-773

Screen.Recording.2024-10-14.at.4.39.04.PM.mov

Test Plan and Hands on Testing

  • Ran throw flows. They are working in themselves outside of EXEC-771

Changelog

  • Added gripper errors to Error Recovery.

@mjhuff mjhuff requested a review from a team October 15, 2024 15:30
@mjhuff mjhuff requested review from a team as code owners October 15, 2024 15:30
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader October 15, 2024 15:30
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.71%. Comparing base (7fb38c9) to head (475cccd).
Report is 23 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #16487      +/-   ##
==========================================
+ Coverage   73.77%   74.71%   +0.94%     
==========================================
  Files          41       42       +1     
  Lines        2989     3117     +128     
==========================================
+ Hits         2205     2329     +124     
- Misses        784      788       +4     
Flag Coverage Δ
shared-data 74.71% <ø> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mjhuff mjhuff force-pushed the app_wire-up-recovery-gripper-cmds branch from 475cccd to 7909bde Compare October 15, 2024 15:48
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice job! thank you!

@mjhuff mjhuff merged commit a3826db into edge Oct 15, 2024
52 checks passed
@mjhuff mjhuff deleted the app_wire-up-recovery-gripper-cmds branch October 15, 2024 16:46
@mjhuff
Copy link
Contributor Author

mjhuff commented Oct 15, 2024

Merged to unblock @TamarZanzouri !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants