-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): create StepSummary component #16484
Conversation
This PR creates and implements the new `StepSummary` component to be shown under the deck map in `ProtocolSteps`. The component produces different messages based on all step types and formats them with inline tags and various StyledText styles. Closes AUTH-857
protocol-designer/src/pages/Designer/ProtocolSteps/StepSummary.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepSummary.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/__tests__/ProtocolSteps.test.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepFormToolbox.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more comment, i think we want the command summaries to update on hover instead of on selected, similarly to how the deck map also updates on hover.
Screen.Recording.2024-10-16.at.08.41.48.mov
Thanks, missed this! I will update the selector to get the hovered step ID |
@ncdiehl11 no worries! i guess it should work similarly to the deck map so it should show on hover but also show on selected if you are not hovering over anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo! awesome work 🤩 🎉 lgtm
Overview
This PR creates and implements the new
StepSummary
component to be shown under the deck map inProtocolSteps
. The component produces different messages based on all step types and formats them with inline tags and various StyledText styles.TODO:
Closes AUTH-857
Test Plan and Hands on Testing
StepSummary
component displays step info at underneath the deck mapChangelog
StepSummary
component and wire up inProtocolSteps
Review requests
Risk assessment
low