Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): create StepSummary component #16484

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Oct 14, 2024

Overview

This PR creates and implements the new StepSummary component to be shown under the deck map in ProtocolSteps. The component produces different messages based on all step types and formats them with inline tags and various StyledText styles.

TODO:

  • add test coverage
  • add "note" text once rename step modal is wired up (reference)

Closes AUTH-857

Test Plan and Hands on Testing

  • Create or import a protocol with a variety of step types
  • In protocol edit view, click steps to select and verify that new StepSummary component displays step info at underneath the deck map

Changelog

  • create new StepSummary component and wire up in ProtocolSteps
  • add translations

Review requests

  • see test plan

Risk assessment

low

This PR creates and implements the new `StepSummary` component to be shown under the deck map in
`ProtocolSteps`. The component produces different messages based on all step types and formats them
with inline tags and various StyledText styles.

Closes AUTH-857
@ncdiehl11 ncdiehl11 self-assigned this Oct 14, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 15, 2024 19:33
@ncdiehl11 ncdiehl11 requested review from a team as code owners October 15, 2024 19:33
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off-deck view which is only visible for a move labware step i think, looks like this:

Screenshot 2024-10-15 at 16 05 48

Otherwise, this is looking great! nice work! love to see the command summaries come to life 🤩

@ncdiehl11
Copy link
Collaborator Author

off-deck view which is only visible for a move labware step i think, looks like this:

Screenshot 2024-10-15 at 16 05 48 Otherwise, this is looking great! nice work! love to see the command summaries come to life 🤩

Thanks! I will figure out what I broke here. Likely an empty fragment instead of a div.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comment, i think we want the command summaries to update on hover instead of on selected, similarly to how the deck map also updates on hover.

Screen.Recording.2024-10-16.at.08.41.48.mov

@ncdiehl11
Copy link
Collaborator Author

one more comment, i think we want the command summaries to update on hover instead of on selected, similarly to how the deck map also updates on hover.

Screen.Recording.2024-10-16.at.08.41.48.mov

Thanks, missed this! I will update the selector to get the hovered step ID

@jerader
Copy link
Collaborator

jerader commented Oct 16, 2024

one more comment, i think we want the command summaries to update on hover instead of on selected, similarly to how the deck map also updates on hover.
Screen.Recording.2024-10-16.at.08.41.48.mov

Thanks, missed this! I will update the selector to get the hovered step ID

@ncdiehl11 no worries! i guess it should work similarly to the deck map so it should show on hover but also show on selected if you are not hovering over anything.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo! awesome work 🤩 🎉 lgtm

@ncdiehl11 ncdiehl11 merged commit ee1aaca into edge Oct 16, 2024
31 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_step-summary branch October 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants