Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Port TipState's nozzle layout to StateUpdate #16479

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Another step towards EXEC-758.

Test Plan and Hands on Testing

  • Make sure analysis snapshot tests keep passing, indicating that tip tracking has not changed.

Changelog

When a ConfigureNozzleLayout command runs, instead of updating TipStore via ConfigureNozzleLayoutPrivateResult, update it via StateUpdate.

Review requests

  • Double-check that the code I'm removing, based on ConfigureNozzleLayoutPrivateResult, is exactly replaced by the code I'm adding, based on StateUpdate.

Risk assessment

I think low, as long as we keep reviewing these diffs carefully.

@SyntaxColoring SyntaxColoring requested a review from a team October 14, 2024 15:54
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner October 14, 2024 15:54
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SyntaxColoring SyntaxColoring merged commit 0b88d87 into edge Oct 14, 2024
27 checks passed
@SyntaxColoring SyntaxColoring deleted the stateupdate_nozzle_layout branch October 14, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants