fix(components): fix logic for whether TC is selected in DeckConfigurator #16476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator In our `DeckConfigurator` component, there is an insufficient equality check for selected cutout ID with configured thermocycler cutout. The situation arises when a thermocycler is configured in cutout A1 and the selected cutout ID is B1, or vice versa. These point to the thermocycler being configured in the same physical location, so we should check whether both selected and configured cutout IDs are included in thermocycler cutouts ([cutoutA1, cutoutB1]). Closes RQA-3237
ncdiehl11
requested review from
mjhuff,
koji and
jerader
and removed request for
a team
mjhuff
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In our
DeckConfiguratorcomponent, there is a leaky equality check for selected cutout ID with configured thermocycler cutout. The situation arises when a thermocycler is configured in cutout A1 and the selected cutout ID is B1, or vice versa. These point to the thermocycler being configured in the same physical location, so we should check whether both selected and configured cutout IDs are included in thermocycler cutouts ([cutoutA1, cutoutB1]).Closes RQA-3237
Test Plan and Hands on Testing
Changelog
DeckConfiguratorfor thermocycler module cutoutsReview requests
see test plan
Risk assessment
low