fix(components): update Icon component to support a svg that has multiple paths #16468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
requested review from
sfoster1,
shlokamin,
smb2268,
brenthagen,
ncdiehl11,
mjhuff and
jerader
|
|
koji
changed the title
|
close this sicne Mel provided new svgs for new icons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update Icon to support a svg that has multiple paths
update icon data types.
add
aria-roledescriptionto Icon and it makes it easy to test whether an icon exists or not.https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-roledescription
Ideally, I should check all icons but unfortunately, we don't have a Figma page that has all icons now.
So I just modify some icons that looked different from the
edge.close AUTH-901 AUTH-922
Test Plan and Hands on Testing
check this pr's icon list is the same as edge's icon list
this prhttps://s3-us-west-2.amazonaws.com/opentrons-components/feat_update-icon-to-support-multiple-paths/index.html?path=/docs/library-atoms-iconlist--docs
edgehttps://s3-us-west-2.amazonaws.com/opentrons-components/edge/index.html?path=/docs/library-atoms-iconlist--docs
Changelog
Review requests
If you have any better idea, please let me know.
Risk assessment
mid because all projects use Icon component