Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, components): add assets for absorbance reader and display them in app #16448

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Oct 9, 2024

Overview

This initial absorbance reader PR adds the design assets, displays them where appropriate, removes the need for calibration and wires up the

Test Plan and Hands on Testing

Changelog

  1. Add icon, SVG rendering and PNG image and wire them up
  2. Wire up module card status to show whether reading or idle and whether the lid is on
  3. Wire up module overflow menu to show one "about module" item
  4. Remove calibration requirement for this module

Review requests

Look through screenshots! You can test this out if you want also

Screen Shot 2024-10-09 at 3 09 43 PM Screen Shot 2024-10-09 at 3 14 44 PM Screen Shot 2024-10-09 at 3 10 31 PM Screen Shot 2024-09-24 at 4 45 57 PM Screen Shot 2024-09-24 at 2 31 10 PM Screen Shot 2024-09-24 at 2 30 56 PM Screen Shot 2024-09-24 at 1 04 47 PM Screen Shot 2024-09-24 at 1 04 33 PM

Risk assessment

Low

@smb2268 smb2268 requested a review from a team as a code owner October 9, 2024 19:34
@smb2268 smb2268 requested review from mjhuff, vegano1, brenthagen and CaseyBatten and removed request for a team October 9, 2024 19:34
@smb2268 smb2268 self-assigned this Oct 9, 2024
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Looks good to merge once CI passes.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

components/src/hardware-sim/Module/PlateReader.tsx Outdated Show resolved Hide resolved
@smb2268 smb2268 merged commit ee8ba20 into edge Oct 10, 2024
35 checks passed
@smb2268 smb2268 deleted the app_plate-reader-ui branch October 10, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants